Swarming: Adds CountTasks endpoint & Refactors swarming Prpc request#5277
Open
IvanBM18 wants to merge 5 commits into
Open
Swarming: Adds CountTasks endpoint & Refactors swarming Prpc request#5277IvanBM18 wants to merge 5 commits into
IvanBM18 wants to merge 5 commits into
Conversation
IvanBM18
changed the title
Xeicker
reviewed
May 15, 2026
Collaborator
Xeicker
left a comment
Xeicker
left a comment
There was a problem hiding this comment.
For future PRs, when you move code and then add functionality it is a good practice to do each of those steps in separate commits for an easier review
IvanBM18
commented
May 15, 2026
| ]) | ||
| self.assertEqual(spec, expected_spec) | ||
|
|
||
| def test_push_swarming_task(self): |
Collaborator
Author
There was a problem hiding this comment.
Note: this test method is no longer needed here, in its place we added unit tests at the api_test that checks for the same functionality
IvanBM18
added
the
swarming
IvanBM18
force-pushed
the
feature/swarming/count_task_requests
branch
from
d45af03 to
562ec1b
Compare
IvanBM18
force-pushed
the
feature/swarming/count_task_requests
branch
from
562ec1b to
57886fc
Compare
Xeicker
approved these changes
May 15, 2026
Collaborator
Xeicker
left a comment
Xeicker
left a comment
There was a problem hiding this comment.
Other than some nits changes LGTM
| message_body = json_format.MessageToJson(count_request) | ||
| logs.info( | ||
| "[Swarming] Counting tasks in queue", | ||
| url=self._base_url, |
Collaborator
There was a problem hiding this comment.
nit
Might be useful to have the complete url in the log
| logs.info("[Swarming] Counting tasks", url=url, body=message_body) | ||
|
|
||
| response = utils.post_url(url=url, data=message_body, headers=headers) | ||
| response = self._make_request('swarming.v2.Tasks/CountTasks', message_body) |
Collaborator
There was a problem hiding this comment.
nit
It sounds to me that endpoints could be module constants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the Swarming backpressure initiative, we needed to launch request to the prpc's
swarming.v2.Task/CountTasksendpoint so we can calculate the amount of fuzz tasks needed to schedule, to achieve this i moved the prpc request logic to its own module so that we can reuse code and keep responsibilities in separate files.Changes
api.pyfile in the swarming module.__init__.pytoapi.pyinit.pyservice.pyto useSwarmingAPIdirectly.SwarmingAPIto handle the prpc request logic such as token/auth logic, swarming config handling, and any other request logicTests
Note:
This PR is dependendant to this other PR any changes you see related to the proto files are to be reviewed in said pr.